feat(config): reject invalid network CIDRs at environment load (PIPE-1002) - #281
Open
Dylan-M wants to merge 1 commit into
Open
Conversation
Assisted-by: Claude Opus 4.8
This was referenced Aug 4, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dylan-M
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #280
Proposed Change
Gates environment load on the network CIDR contract.
EnvironmentConfig.Buildvalidates every resolved network's CIDR (
datagen.ValidateCIDRrejects unparseable,non-IPv4, and prefixes longer than
/29) and fails the load naming the offendingCIDR, rather than silently defaulting.
Generated networks are always valid today, so this is the enforcement point for when
user-supplied CIDRs arrive through config.
Validation: no user-facing CIDR input exists yet, so the gate can't be exercised
from a config file; it's covered by unit tests.
validateNetworksaccepts validIPv4 networks and rejects
/30-/32, non-IPv4, and malformed CIDRs, andBuildfails on an injected invalid network and propagates a generation error.
Checklist